Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse response's has-cross-origin-redirects #8405

Merged
merged 3 commits into from Oct 22, 2022

Conversation

abinpaul1
Copy link
Contributor

@abinpaul1 abinpaul1 commented Oct 19, 2022

Reuse response's has-cross-origin-redirects in place of navigation param's has cross-origin redirects boolean.

Discussion : whatwg/fetch#1468 (comment)


/browsing-the-web.html ( diff )
/infrastructure.html ( diff )

source Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, always great to make navigation params smaller.

source Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @annevk or I will merge when the Fetch merge happens.

@domenic domenic added the do not merge yet Pull request must not be merged per rationale in comment label Oct 22, 2022
annevk pushed a commit to whatwg/fetch that referenced this pull request Oct 22, 2022
Resource Timing PR: w3c/resource-timing#335.

HTML PR: whatwg/html#8405.

Follow-up to provide more clarity around filtered responses (which this relies on): #1509.
@annevk annevk merged commit 478e131 into whatwg:main Oct 22, 2022
@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Oct 22, 2022
@abinpaul1 abinpaul1 deleted the migrate-has-cross-origin-redirect branch October 22, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants