Fix the steps to find a point on an ellipse #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt at fixing whatwg#8408. This goes the long way of defining the steps to determine the point on the ellipse, in a "theoretical" wording (as opposed to using algebra formulae). This is based on what browsers seems to do. so there shouldn't be a need for browser issues, yet a technical review from @whatwg/canvas is probably necessary. Not sure either if editorially this is the proper way of fixing that.
|
cc @whatwg/canvas (pr-preview cannot mention teams so mentioning them in OP often fails) |
domenic
reviewed
Nov 16, 2022
domenic
approved these changes
Nov 16, 2022
|
Anyone from @whatwg/canvas want to provide a quick check on the logic here? I'll plan on merging this by Monday the 16th if we don't hear otherwise. |
|
I think this makes sense. Thanks, @Kaiido for doing this. :) |
|
Gentle ping @domenic, I guess this went off your radar ;-) |
teoli2003
added a commit
to mdn/content
that referenced
this pull request
Feb 24, 2023
* Fix ellipse angles definition As was found in whatwg/html#8408 the ellipse's `startAngle` and `endAngle` are not really angles on the ellipse, but angles on the eccentric circle of the ellipse. These are known as "eccentric angle", though this term *might* be a bit obscure at first sight, so I wouldn't mind a better proposition if reviewers have one. The specs got fixed in whatwg/html#8495 but as can be seen, the fix was quite verbose and I'm not sure the docs need to get that much details. So I hope this little fix is both enough to lead the ones that could get surprised by the actual behavior to the proper understanding, and not too obscure to lose in details the ones that wouldn't notice. * Link "eccentric angle" to outside explanation Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> * Should have batched... Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com> --------- Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #8408.
This goes the long way of defining the steps to determine the point on the ellipse, in a "theoretical" wording (as opposed to using algebra formulae).
This is based on what browsers seems to do, so there shouldn't be a need for browser issues, yet a technical review from @whatwg/canvas is probably necessary.
Not sure either if editorially this is the proper way of fixing that.
Ps: Also CCing @flupe since they were the ones discovering this in the first place.
(See WHATWG Working Mode: Changes for more details.)
/canvas.html ( diff )