Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove font tag text decoration quirk. #8568

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Remove font tag text decoration quirk. #8568

merged 1 commit into from
Dec 2, 2022

Conversation

bfgeek
Copy link
Member

@bfgeek bfgeek commented Nov 30, 2022 •
edited by domenic
Loading

domenic
domenic approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be addressing #8566. Let us know when you have multi-implementer interest and tests, and then we can merge.

@domenic domenic added normative change topic: rendering needs tests Moving the issue forward requires someone to write tests labels Dec 1, 2022
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Dec 1, 2022
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 1, 2022
@bfgeek @chromium-wpt-export-bot
[text-decorations] Add & enable flag to disable text-decoration override
f8379e0 
This adds and enables a flag to disable the non-standard text-decoration
color override logic.

This "quirk" was only ever meant to be for the <font> element (not for
the <a> element) and in quirks mode.

Firefox applies this quirk in a far reduced set of circumstances, and
likely isn't required by web content anymore.

This is hooked up to a finch kill-switch so we can disable if necessary.

See:
whatwg/html#8568
whatwg/html#8566

Bug: 1394817
Change-Id: Icdf86b1099c81571729767b56a7b3aaee7c85e7d
@bfgeek
Copy link
Member Author

bfgeek commented Dec 1, 2022

@domenic PTAL - (updated top post with vendor interest, and test pull request)

This does carry some (very) small compat risk - I've wired up our logic change to a kill-switch flag in anything goes wrong. We'll know for sure in early Feburary.

@domenic domenic removed the needs tests Moving the issue forward requires someone to write tests label Dec 2, 2022
@domenic
Copy link
Member

domenic commented Dec 2, 2022

Great! I'll merge this. Please file Safari and Firefox bugs and update the OP with them, for tracking.

@domenic domenic merged commit 055bc6b into whatwg:main Dec 2, 2022
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 2, 2022
@bfgeek @chromium-wpt-export-bot
[text-decorations] Add & enable flag to disable text-decoration override
5483064 
This adds and enables a flag to disable the non-standard text-decoration
color override logic.

This "quirk" was only ever meant to be for the <font> element (not for
the <a> element) and in quirks mode.

Firefox applies this quirk in a far reduced set of circumstances, and
likely isn't required by web content anymore.

This is hooked up to a finch kill-switch so we can disable if necessary.

See:
whatwg/html#8568
whatwg/html#8566

Bug: 1394817
Change-Id: Icdf86b1099c81571729767b56a7b3aaee7c85e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066694
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078424}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 2, 2022
@bfgeek @chromium-wpt-export-bot
[text-decorations] Add & enable flag to disable text-decoration override
8646f9f 
This adds and enables a flag to disable the non-standard text-decoration
color override logic.

This "quirk" was only ever meant to be for the <font> element (not for
the <a> element) and in quirks mode.

Firefox applies this quirk in a far reduced set of circumstances, and
likely isn't required by web content anymore.

This is hooked up to a finch kill-switch so we can disable if necessary.

See:
whatwg/html#8568
whatwg/html#8566

Bug: 1394817
Change-Id: Icdf86b1099c81571729767b56a7b3aaee7c85e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066694
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078424}
@bfgeek
Copy link
Member Author

bfgeek commented Dec 2, 2022

@domenic Done - Thanks!

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 11, 2022
@bfgeek @moz-wptsync-bot
Bug 1803716 [wpt PR 37283] - [text-decorations] Add & enable flag to …
e53d9e7 
…disable text-decoration override, a=testonly

Automatic update from web-platform-tests
[text-decorations] Add & enable flag to disable text-decoration override

This adds and enables a flag to disable the non-standard text-decoration
color override logic.

This "quirk" was only ever meant to be for the <font> element (not for
the <a> element) and in quirks mode.

Firefox applies this quirk in a far reduced set of circumstances, and
likely isn't required by web content anymore.

This is hooked up to a finch kill-switch so we can disable if necessary.

See:
whatwg/html#8568
whatwg/html#8566

Bug: 1394817
Change-Id: Icdf86b1099c81571729767b56a7b3aaee7c85e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066694
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078424}

--

wpt-commits: 8646f9fc564439fe5c7582ce5d73a86427a57cf2
wpt-pr: 37283
BruceDai pushed a commit to BruceDai/wpt that referenced this pull request Dec 13, 2022
@bfgeek @BruceDai
[text-decorations] Add & enable flag to disable text-decoration override
913dba1 
This adds and enables a flag to disable the non-standard text-decoration
color override logic.

This "quirk" was only ever meant to be for the <font> element (not for
the <a> element) and in quirks mode.

Firefox applies this quirk in a far reduced set of circumstances, and
likely isn't required by web content anymore.

This is hooked up to a finch kill-switch so we can disable if necessary.

See:
whatwg/html#8568
whatwg/html#8566

Bug: 1394817
Change-Id: Icdf86b1099c81571729767b56a7b3aaee7c85e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066694
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078424}
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Dec 14, 2022
@bfgeek @moz-wptsync-bot
Bug 1803716 [wpt PR 37283] - [text-decorations] Add & enable flag to …
ede6d3b 
…disable text-decoration override, a=testonly

Automatic update from web-platform-tests
[text-decorations] Add & enable flag to disable text-decoration override

This adds and enables a flag to disable the non-standard text-decoration
color override logic.

This "quirk" was only ever meant to be for the <font> element (not for
the <a> element) and in quirks mode.

Firefox applies this quirk in a far reduced set of circumstances, and
likely isn't required by web content anymore.

This is hooked up to a finch kill-switch so we can disable if necessary.

See:
whatwg/html#8568
whatwg/html#8566

Bug: 1394817
Change-Id: Icdf86b1099c81571729767b56a7b3aaee7c85e7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066694
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1078424}

--

wpt-commits: 8646f9fc564439fe5c7582ce5d73a86427a57cf2
wpt-pr: 37283
@Ahmad-S792 Ahmad-S792 mentioned this pull request Nov 29, 2023
Merged
webkit-commit-queue pushed a commit to Ahmad-S792/WebKit that referenced this pull request Nov 30, 2023
@Ahmad-S792
Remove font text-decoration color override quirk
0f4bbb2 
https://bugs.webkit.org/show_bug.cgi?id=248662
rdar://problem/102920597

Reviewed by Antti Koivisto.

This patch is to align WebKit with Gecko / Firefox (except one case), Blink / Chromium and
Web Specification [1] (relevant issue [2]):

[1] https://html.spec.whatwg.org/#phrasing-content-3
[2] whatwg/html#8568

As per above issue, this patch remove quirk around 'font' element overriding color of
any text decoration.
Additionally, it also import updated tests from WPT:

Upstream Hash: web-platform-tests/wpt@9f9188a

* Source/WebCore/rendering/TextDecorationPainter.cpp:
(collectStylesForRenderer):
* LayoutTests/TestExpectations: Add all imported tests as [ImageOnlyFailure] due to slight pixel shifts
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-a.html: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-a-expected.html: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-q.html: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-q-expected.html: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-s.html: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-s-expected.html: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-ref.html: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-x.xhtml: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/phrasing-content-0/font-element-text-decoration-color/001-x-expected.html: Ditto

Canonical link: https://commits.webkit.org/271338@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
normative change topic: rendering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bfgeek @domenic