Editorial: synchronize with the DOM Standard #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This cleanup will be useful when integrating Shadow DOM. Some more might be needed, but this is a good start and fixes a legacy bug. |
| <p>If the root | ||
| element of the resulting <code>Document</code> has any sibling nodes, then throw a | ||
| <code>SyntaxError</code> exception and abort these steps.</p> | ||
| <p>If the document element of the resulting <code>Document</code> has any sibling nodes, then |
There was a problem hiding this comment.
xref document element? (Also elsewhere)
|
Added some further cleanup. Please take another look. |
|
LGTM |
This makes a couple of editorial changes: * Instead of "root element" we now use "root" or "document element" * Instead of "home subtree" we simply use "tree" * "In a document" is now referenced * Usage of replaceChild() has been replaced with concept-node-replace * Usage of insertBefore() has been replaced with concept-node-pre-insert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a couple of editorial changes:
Fixes: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28039.