Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: formalize reflect's default value #8931

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 22, 2023

And rename some number-related options to be less verbose and more consistent.

Fixes #8926 and fixes #8927.


/common-dom-interfaces.html ( diff )
/form-elements.html ( diff )
/grouping-content.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/obsolete.html ( diff )
/tables.html ( diff )

And rename some number-related options to be less verbose and more consistent.

Fixes #8926 and fixes #8927.
@annevk annevk added the clarification Standard could be clearer label Feb 22, 2023
@annevk annevk requested a review from domenic February 22, 2023 13:12
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like especially how this gives us back-links to the "default value" term from the reflected IDL attribute declarations.

@annevk annevk merged commit a32ab9b into main Feb 27, 2023
@annevk annevk deleted the annevk/reflect-default-value branch February 27, 2023 14:10
@tabatkins
Copy link
Collaborator

I still think "positive", by itself, is ambiguous. Can I suggest "positive non-zero" again?

@domenic
Copy link
Member

domenic commented Feb 27, 2023

I strongly disagree that's it's ambiguous. Positive is defined as > 0. Positive and non-negative are clearly non-overlapping categories.

@tabatkins
Copy link
Collaborator

And like I said in my linked comment, that is not true, particularly in the context of the web platform. JS's zero is positive or negative, not unsigned, for example. (Even Math.sign() agrees, as it turns out, since it actually has four possible results: +1, -1, +0, or -0.)

We've had confusion about this exact issue in CSS in the past. I'm not sure if we're 100% consistent, but I know I have rewritten text to be more explicit, at the request of readers who were genuinely unsure.

@annevk
Copy link
Member Author

annevk commented Feb 28, 2023

These terms are defined in a way that is unambiguous. In Infra we can take that a step further once we get around to numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer
3 participants