Correct WAI-ARIA integration for custom elements #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires corresponding changes in https://w3c.github.io/core-aam/ as discussed in w3c/core-aam#152.
annevk
added
accessibility
|
If #8962 lands first this will need changes to account for that and vice versa. |
4 tasks
domenic
reviewed
Mar 3, 2023
| @@ -14249,6 +14253,19 @@ interface <dfn interface>DOMStringMap</dfn> { | |||
| <li><p>If <var>map</var>[<var>stateOrProperty</var>] <span data-x="map exists">exists</span>, | |||
| then return it.</p></li> | |||
|
|
|||
| <li> | |||
There was a problem hiding this comment.
I think we should prioritize this higher than the internal content attribute map. Otherwise, for the element-valued properties you'll get the empty string.
annevk
added
the
topic: reflect
domenic
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires corresponding changes in https://w3c.github.io/core-aam/ as discussed in w3c/core-aam#152.
@scottaohara @alice @spectranaut I think WAI-ARIA will want to define a similar contract around ARIA properties. Namely that for each of them you get a string, element, list of elements, or their default value.
/common-dom-interfaces.html ( diff )
/custom-elements.html ( diff )
/dom.html ( diff )