-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "lbry" scheme to allowlist #9017
Conversation
Also see #9016. |
Hello @domenic, I see you added the |
Tagging @brave here. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Chromium seems interested to implement this as soon as this is spec. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Hi @domenic, I think I've done everything. Did I miss something? If not, I think it can be merged. The specification |
This cannot be merged, because it does not have multi implementer interest. An open bug does not suffice; we need an implementer representative to say on this thread "we will ship this in our browser", for two different browsers. |
Hi @domenic, can this be two browsers that use the same browser engine or should those be different? Because Brave browser seemed interested too, but they are using Chromium, that also was interested. |
They need to be separate browser engines. |
Okay, thanks for letting me know. WebKit cannot implement it because they don't support I have another question, maybe for future pull requests too: Next to Chromium, Gecko and Mozilla, can I ask smaller browser engines too? For example, a representive of one of the browser engines listed at https://en.wikipedia.org/wiki/Comparison_of_browser_engines, libweb for the Ladybird browser, @awesomekling, seems really accessible to ask such questions. |
For Mozilla, I think it is either @petervanderbeken or @evilpie that can tell if they are interested. |
I would expect that until Ladybird actually passes a significant portion (>75%?) of WPT, LibWeb agreeing to ship a feature would not meet the standard required for "implementer interest" for the spec. |
For Mozilla, we are not interested in adding |
Hi @zcorpan, thank you for your response. May I know the reason for not being interested in adding Edit: |
Given that this cannot meet the bar for two-implementer interest, since neither Mozilla nor Apple are interested, I will close this. (We can, of course, reopen if either changes their mind.) |
Hi @domenic, I agree, but you didn't answer #9017 (comment) yet. Does the rule of interested browser engine developers also apply to smaller browser engines, like LibWeb? |
No. |
Hmmm okay. Good too know. |
We will add support for this if it gets merged to the HTML spec
lbry
, because they don't supportregisterProtocolHandler
at all. However, they didn't oppose.(See WHATWG Working Mode: Changes for more details.)
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Feb 3, 2024, 3:29 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.