Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix var/ref name mismatch with s/intendToStoreInBfcache/intendToKeepInBfcache/ #9170

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix var/ref name mismatch with s/intendToStoreInBfcache/intendToKeepInBfcache/ #9170

merged 1 commit into from
Apr 17, 2023

Conversation

jan-ivar
Copy link
Contributor

@jan-ivar jan-ivar commented Apr 14, 2023 •
edited by pr-preview bot

intendToStoreInBfcache is unused, but intendToKeepInBfcache is used. I picked the latter since the core here seems to be about keeping something alive.

/document-lifecycle.html ( diff )

@jan-ivar jan-ivar mentioned this pull request Apr 14, 2023
Closed
domenic
domenic approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@domenic domenic merged commit d635f0b into whatwg:main Apr 17, 2023
1 check passed
@jan-ivar jan-ivar deleted the tostoreorkeep branch April 17, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: history
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-ivar @domenic