Change table's height attribute to allow zero-like values #9374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Great work!
Optional:
- You can add yourself to the acknowledgments section of the spec (Ctrl+F for
<!-- ACKS - Rewrap this paragraph, using https://domenic.github.io/rewrapper/
|
Also don't forget to sign the Participant Agreement, or have your company do so. |
|
Thanks for the really fast review! And woops, all of those should be done now. 🙂 Also, when signing the participant agreement I think I added both the "dom" and "html" workstreams, although in hindsight I probably should have done just "html". Not sure if that matters but FYI. |
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 3, 2023
Follows whatwg/html#9374 for <table>, and the existing spec for <tr> and <col>.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 13, 2023
…t, and <col> width , a=testonly Automatic update from web-platform-tests Allow zero on certain elem dimensions to match current browser behavior Follows whatwg/html#9374 for <table>, and the existing spec for <tr> and <col>. -- wpt-commits: 3d953f9b12fee56e131eec7a8ef5400a38b1d206 wpt-pr: 40350
ErichDonGubler
pushed a commit
to ErichDonGubler/firefox
that referenced
this pull request
Jun 14, 2023
…t, and <col> width , a=testonly Automatic update from web-platform-tests Allow zero on certain elem dimensions to match current browser behavior Follows whatwg/html#9374 for <table>, and the existing spec for <tr> and <col>. -- wpt-commits: 3d953f9b12fee56e131eec7a8ef5400a38b1d206 wpt-pr: 40350
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 16, 2023
…t, and <col> width , a=testonly Automatic update from web-platform-tests Allow zero on certain elem dimensions to match current browser behavior Follows whatwg/html#9374 for <table>, and the existing spec for <tr> and <col>. -- wpt-commits: 3d953f9b12fee56e131eec7a8ef5400a38b1d206 wpt-pr: 40350 UltraBlame original commit: 9af68c7cf2f87debee7e6eb7bd9094e16f31dab6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 16, 2023
…t, and <col> width , a=testonly Automatic update from web-platform-tests Allow zero on certain elem dimensions to match current browser behavior Follows whatwg/html#9374 for <table>, and the existing spec for <tr> and <col>. -- wpt-commits: 3d953f9b12fee56e131eec7a8ef5400a38b1d206 wpt-pr: 40350 UltraBlame original commit: 9af68c7cf2f87debee7e6eb7bd9094e16f31dab6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 16, 2023
…t, and <col> width , a=testonly Automatic update from web-platform-tests Allow zero on certain elem dimensions to match current browser behavior Follows whatwg/html#9374 for <table>, and the existing spec for <tr> and <col>. -- wpt-commits: 3d953f9b12fee56e131eec7a8ef5400a38b1d206 wpt-pr: 40350 UltraBlame original commit: 9af68c7cf2f87debee7e6eb7bd9094e16f31dab6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the table's
heightattribute would not allow dimension values that evaluated to zero after being parsed. Now, theheightattribute will respect zero.Hopefully not applicable? We're just aligning the spec with current behavior.
Allow zero on <table> height, <tr> height, and <col> width web-platform-tests/wpt#40350
N/A, we're aligning the spec with current browser behavior.
I don't think we need to do this, I didn't find anything relevant on the table's MDN page.
/acknowledgements.html ( diff )
/rendering.html ( diff )