Fix modal check in dialog closing algorithm #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value for is modal needs to be cached. This was pointed out here: whatwg#9178 (comment)
3 tasks
nt1m
added
topic: popover
nt1m
approved these changes
Jun 7, 2023
annevk
approved these changes
Jun 7, 2023
|
(I've ignored the PR template as this appeared to be a straightforward bug fix.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value for is modal needs to be cached. This was pointed out here: #9178 (comment)
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )