Clarify the fake token step in fragment parsing #9430
Conversation
|
|
||
| <p>Let this start tag token be the start tag token of the <var | ||
| data-x="concept-frag-parse-context">context</var> node, e.g. for the purposes of determining | ||
| data-x="concept-frag-parse-context">context</var> node. This token is only used for determining | ||
| if it is an <span>HTML integration point</span>.</p> |
There was a problem hiding this comment.
Could you turn this into a single sentence along the lines I suggested? Using "Let" to set an internal member of the context element (or node, we should be consistent) is weird.
|
We currently have interop on this point: The attributes of the context node are ignored: https://software.hixie.ch/utilities/js/live-dom-viewer/saved/11842 It seems like a bug, but given that it's interoperable, do we want to keep it that way? In any case, implementation-wise, I don't like writing the spec in the way that copies all the attributes if we only look at one (or currently, as implemented, none). I'd much prefer taking the local name for the context node, the namespace for the context node, and whatever flags actually need to be inspected. Currently in Gecko, there's a flag for quirks mode. If we decide we want to change the browser behavior here, I'd prefer to have a flag that true iff the context node is That way, it would be clear that the fragment parsing algorithm doesn't actually need a copy of all the attributes. |
|
That's true, but then we'd have to change a whole lot more, to pass through that flag and make it do the correct thing. We could make it more precise though and only copy that attribute and only if it has one of those values. That seems like a more minimal fix that still has the desired effect. And it does seem bad that this would not work as expected, so I'd recommend we all fix it. Also, I'm guessing we can't turn cc @mfreed7 |
Fixes #9428
馃挜 Error: Wattsi server error 馃挜
PR Preview failed to build. (Last tried on Jun 15, 2023, 2:18 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
馃毃 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
馃敆 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.