Make dirname apply to hidden/tel/url/email inputs #9490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Jul 7, 2023
| data-x="attr-input-type-text">Text</span>, <span data-x="attr-input-type-search">Search</span>, | ||
| <span data-x="attr-input-type-url">URL</span>, <span | ||
| data-x="attr-input-type-tel">Telephone</span>, or <span | ||
| data-x="attr-input-type-email">Email</span> state, if the persisted state includes the |
There was a problem hiding this comment.
Can you make the order of the states here match the order you used above? (That order matches the table of contents order.)
|
A test is located in html/semantics/forms/attributes-common-to-form-controls/dirname-only-if-applies.html and the necessary change can be seen here |
|
@annevk zcorpan is out of office. Can you address the nit and I'll file the implementation bugs, MDN issue? |
|
bsmth
added a commit
to mdn/content
that referenced
this pull request
Aug 10, 2023
* Make dirname apply to hidden/tel/url/email inputs. See whatwg/html#9490 * Apply nit Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> * Update files/en-us/web/html/element/input/index.md Co-authored-by: Brian Thomas Smith <brian@smith.berlin> * Link to dirname page --------- Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9225
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/form-control-infrastructure.html ( diff )
/input.html ( diff )