Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasUAVisualTransition attribute to popState and navigate event #9579

Merged
merged 7 commits into from Aug 17, 2023

Conversation

khushalsagar
Copy link
Contributor

@khushalsagar khushalsagar commented Aug 3, 2023

Fixes #8782

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
    • In-progress change here. WPTs assert that the new attribute exists on the events but by design can't test what the value is set to, since that's left to the UA.
  • Implementation bugs are filed:
  • MDN issue is filed: …

/acknowledgements.html ( diff )
/browsing-the-web.html ( diff )
/nav-history-apis.html ( diff )

@domenic
Copy link
Member

domenic commented Aug 7, 2023

This unfortunately is not how to specify this behavior.

To do this, you need to properly initialize these attributes at each place that the events are fired. Those places are:

@khushalsagar
Copy link
Contributor Author

Done. I wasn't sure what to write when defining the attribute, seemed redundant to write the same explanation.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some polish work to do.

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@khushalsagar
Copy link
Contributor Author

Done, ready for another review.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to fix the line wrapping. With that, this is good to go.

Also, please feel free to add your name to the acknowledgments section if you'd like!

@domenic domenic added addition/proposal New features or enhancements topic: navigation labels Aug 14, 2023
@domenic domenic merged commit 1acea73 into whatwg:main Aug 17, 2023
2 checks passed
@domenic
Copy link
Member

domenic commented Aug 17, 2023

All merged! Please file an MDN issue when you get the chance, and update the OP for posterity to link to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements topic: navigation
Development

Successfully merging this pull request may close these issues.

Detect UA transitions on same-document navigations
2 participants