Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specificity issue for <embed hidden> #9664

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Aug 31, 2023

The embed[hidden] rule was intended to override 'display' but had lower specificity.

Fixes #9564.

(See WHATWG Working Mode: Changes for more details.)


/rendering.html ( diff )

The embed[hidden] rule was intended to override 'display' but had lower specificity.

Fixes #9564.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not quite sure what the multi-implementer interest status is for this but I'll trust you to figure that out before merging.

@zcorpan
Copy link
Member Author

zcorpan commented Sep 4, 2023

hidden=until-found is only implemented in Chromium, but it still passes the test, so it seems it somehow didn't have the bug that the spec had. WebKit and Gecko also pass the display part of the test, so I think we can treat this as a spec-only bug fix.

FYI @josepharhar

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Sep 4, 2023
@zcorpan zcorpan merged commit ecbf55b into main Sep 4, 2023
2 checks passed
@zcorpan zcorpan deleted the zcorpan/hidden-specificity-wars branch September 4, 2023 19:24
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 13, 2023
…mbed hidden=until-found>, a=testonly

Automatic update from web-platform-tests
HTML: rendering of <embed hidden> and <embed hidden=until-found>

See whatwg/html#9664

--

wpt-commits: b6d002e21b44f4afd75bf1d959c65a1e5ce3c927
wpt-pr: 41733
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Sep 14, 2023
…mbed hidden=until-found>, a=testonly

Automatic update from web-platform-tests
HTML: rendering of <embed hidden> and <embed hidden=until-found>

See whatwg/html#9664

--

wpt-commits: b6d002e21b44f4afd75bf1d959c65a1e5ce3c927
wpt-pr: 41733
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Standardize UA styles / presentational hints for embed hidden
2 participants