Correct <source> dimension property handling #9752
Conversation
|
@BorisChiou @emilio could you confirm this fixes the issue? Furthermore we probably don't need additional test coverage for this as https://github.com/web-platform-tests/wpt/blame/master/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/picture-aspect-ratio.html by @cbiesinger already covers this? Maybe he could review this too. |
There was a problem hiding this comment.
The commit message would probably benefit from mentioning the specific example this is meant to fix (#8178 (comment))
I'm undecided on whether I like this change in general, but since there's no way to specify height="auto" in HTML I guess this is an improvement.
| <p>When the text below says that an attribute <var>attribute</var> on an element | ||
| <var>element</var> <dfn>maps to the dimension property (with fallback)</dfn> (or properties) | ||
| <var>properties</var>, then <var>attribute</var> on <var>element</var> <span>maps to the dimension | ||
| property</span> <var>properties</var>. And if <var>element</var> does not have an attribute |
There was a problem hiding this comment.
This should probably treat a parse error the same as a missing attribute?
(ref: line 128634)
There was a problem hiding this comment.
Thanks, pushed a fix for that.
I'll make sure to include the example in the commit message when landing this.
annevk
added
the
do not merge yet
|
As per #8178 (comment) this whole PR might be unneeded. If that's true (and it seems like it is) I suggest we close this PR and create a new one for the note, to avoid confusion. |
Fixes #8178.
(See WHATWG Working Mode: Changes for more details.)
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Sep 20, 2023, 8:41 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.