Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagereveal event #9818

Merged
merged 15 commits into from
Dec 15, 2023
Merged

Add pagereveal event #9818

merged 15 commits into from
Dec 15, 2023

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Oct 1, 2023

Add pagereveal event, and the PageRevealEvent interface.
The pagereveal event is fired at the beginning of the first rendering opportunity after activation (initial load or reactivation).
It is a way for the author to execute some JS that affects the presentation "just in time" for the first frame.
If there is an inbound cross-document view transition, the reveal event holds a reference to the ViewTransition object.

Closes #9315.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/nav-history-apis.html ( diff )
/webappapis.html ( diff )

Copy link
Contributor

@bokand bokand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

source Outdated Show resolved Hide resolved
@noamr noamr mentioned this pull request Oct 16, 2023
4 tasks
@noamr noamr changed the title WIP-reveal Add pagereveal event Oct 16, 2023
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@noamr
Copy link
Contributor Author

noamr commented Oct 24, 2023

@smaug---- @domenic I think this is ready for review, I checked the appropriate boxes.

source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@noamr
Copy link
Contributor Author

noamr commented Dec 1, 2023

@domenic I think this is ready for another run.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Found a few new nits, and several old ones did not get resolved, including:

source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
Copy link
Contributor Author

@noamr noamr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the missed comments, apparently some comments appear in the review pane and not in the comments pane...

source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
@domenic domenic added addition/proposal New features or enhancements topic: navigation labels Dec 13, 2023
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did push one more commit to move the event interface back into event interfaces.

Since Gecko has been quite involved in reviewing this, and hasn't yet given a clear "LGTM", I'll give folks like @smaug---- and @zcorpan another day or two to weigh in before we merge. But I agree with your current assessment that there seems to be Gecko support, so unless I hear otherwise I'll default to merging soon.

@domenic domenic merged commit 6bc6e2d into whatwg:main Dec 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Proposal: fire an event before the first rendering opportunity after activation
4 participants