Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLAllCollection: add tags() method #9908

Closed
wants to merge 1 commit into from

Conversation

delan
Copy link
Contributor

@delan delan commented Nov 2, 2023

HTMLAllCollection historically had a tags() method, but it is currently only implemented in […].

As some evidence of its notability, the method is discussed explicitly in Using Dynamic HTML (1997) by Gulbransen and Rawlings, pages 115, 116, and 119. I have also seen it in the wild in scripts like the one below, which now needs many patches to run in modern browsers.

https://web.archive.org/web/20231102153828id_/https://mazdamanuals.com.au/wsm-secure/WSM/D926-1A-22C_Ver28/esicont/esi_common/toc.js

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/common-dom-interfaces.html ( diff )
/infrastructure.html ( diff )

@zcorpan
Copy link
Member

zcorpan commented Nov 6, 2023

tags was removed from Gecko in 2008 (Firefox 3), Chromium in 2014 and WebKit in 2017. It was removed from the spec in 2014. That it once existed isn't a good reason to specify it and implement it again. 🙂

https://bugzilla.mozilla.org/show_bug.cgi?id=874084
https://bugs.webkit.org/show_bug.cgi?id=169337
https://codereview.chromium.org/148693003
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22118

@delan
Copy link
Contributor Author

delan commented Nov 13, 2023

Thanks for the pointers, I was unaware that it was previously removed.

I think that was somewhat misguided — for example, the Blink intent cited incorrect use counter data, and claimed it was removed in IE11 which was not the case. That said, other decisions were more reasonable, such as Gecko removing it after finding out it was broken without complaints for five years.

I would be happy to build a case for restoring it by filing impl bugs and/or reimplementing it in at least Servo.

@domenic
Copy link
Member

domenic commented Nov 13, 2023

Let's close this until there's implementer interest. I can state pretty confidently Chrome is not interested, but if Safari and Firefox both are, then we can consider adding it to the spec.

@domenic domenic closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants