Add list clone, subsets, supersets, intersection and union #155
Conversation
infra.bs
Outdated
| <p>To <dfn export for=list,stack,queue,set>clone</dfn> a <a>list</a> |list| is to create a new | ||
| <a>list</a> |clone| and, <a for=list>for each</a> |item| of |list|, <a for=list>append</a> |item| | ||
| to |clone|, so that |clone| <a for=list>contains</a> the same <a for=list>items</a>, in the same | ||
| order as |list|. |
There was a problem hiding this comment.
If you're making this explicit, you'd also have to explicitly clone the item. Or is the intent that they point to the same item?
There was a problem hiding this comment.
That's always the question isn't it? I assumed we'd add deep cloning if the behavior you describe was ever required.
infra.bs
Outdated
| |superset| (and conversely, |superset| is a <dfn export for=set>superset</dfn> of |set|) if, | ||
| <a for=list>for each</a> |item| of |set|, |superset| <a for=set>contains</a> |item|. Note that this | ||
| implies that an <a>ordered set</a> is both a <a for=set>subset</a> and a <a for=set>superset</a> of | ||
| itself. |
There was a problem hiding this comment.
Note should be in a <span class=note> or its own paragraph.
| @@ -715,6 +715,11 @@ performing a set of steps on each <a for=list>item</a> in order, use phrasing of | |||
| "<a for=list>For each</a> |item| of <var ignore>list</var>", and then operate on |item| in the | |||
| subsequent prose. | |||
|
|
|||
| <p>To <dfn export for=list,stack,queue,set>clone</dfn> a <a>list</a> |list| is to create a new | |||
There was a problem hiding this comment.
I think we should expand on this in two ways:
NOTE: this is a "shallow clone", as the items themselves are not cloned in any way
plus something about how cloning a specific type of list (stack/queue/ordered set) produces a list which is also one of those things. Maybe with an example?
|
Do you want me to rebase those into 4 distinct commits (clone, subset & superset, intersection, union) or are you planning to mash them altogether into one (I don't care either way). |
|
I'd go for mash. Just wanting @annevk to sign off too before doing so. |
Closes #154.
Preview | Diff