Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct variable name in base64 algorithm #195

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Correct variable name in base64 algorithm #195

merged 1 commit into from
Apr 17, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 17, 2018 •
edited by pr-preview bot
Loading

(Also address some Bikeshed nits.)

Preview | Diff

@annevk
Correct variable name in base64 algorithm
de260dc 
(Also address some Bikeshed nits.)
@annevk annevk requested a review from domenic April 17, 2018 11:35
@annevk annevk mentioned this pull request Apr 17, 2018
Merged
domenic
domenic approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer these as two separate commits, but LGTM.

@annevk annevk merged commit fcacad0 into master Apr 17, 2018
@annevk annevk deleted the annevk/base64-variable branch April 17, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @domenic