Revise the way otherwise is supposed to be used #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also clarifies how "get the value of an entry" for an ordered map actually works. Closes #247.
domenic
reviewed
May 17, 2019
infra.bs
Outdated
| <var ignore>target</var>, if <var ignore>isActivationEvent</var> is true and target has activation | ||
| behavior, and null otherwise. | ||
| <var ignore>target</var> if <var ignore>isActivationEvent</var> is true and target has activation | ||
| behavior, otherwise null. |
There was a problem hiding this comment.
As @sideshowbarker noted this should be a semicolon, not a comma.
There was a problem hiding this comment.
That was in reaction to the ", null otherwise" variant. Also, it's not the style we used in https://infra.spec.whatwg.org/#code-unit-prefix.
Closed
sideshowbarker
approved these changes
May 20, 2019
domenic
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also clarifies how "get the value of an entry" for an ordered map actually works.
Closes #247.
Preview | Diff