Change substring semantics to be about positions, not indices #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added a commit
to domenic/service-worker-scope-pattern-matching
that referenced
this pull request
Sep 21, 2021
triple-underscore
approved these changes
Sep 22, 2021
annevk
approved these changes
Sep 22, 2021
Previously, the spec attempted to use code unit/point indices in the substring definitions. However, this mismatched how most programming languages do substring operations, and was buggy, as noted in #402. This changes the definitions to operate on "positions" between code units/points, instead of indices, with a note explaining the difference. The resulting prose then matches most programming languages, as well as the JavaScript specification's less-formal "substring" definition. Closes #402.
domenic
force-pushed
the
substring-fix-again
branch
from
d0d2ff0
to
64e93fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the spec attempted to use code unit/point indices in the substring definitions. However, this mismatched how most programming languages do substring operations, and was buggy, as noted in #402.
This changes the definitions to operate on "positions" between code units/points, instead of indices, with a note explaining the difference. The resulting prose then matches most programming languages, as well as the JavaScript specification's less-formal "substring" definition.
Closes #402.
Thanks @triple-underscore! Your review would be appreciated.
Fixes to other specs:
Preview | Diff