Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal GitHub labels on WHATWG spec repos? #162

Closed
plehegar opened this issue Mar 17, 2020 · 22 comments · Fixed by #164
Closed

Horizontal GitHub labels on WHATWG spec repos? #162

plehegar opened this issue Mar 17, 2020 · 22 comments · Fixed by #164

Comments

@plehegar
Copy link

Long story short, W3C is switching to use GitHub labels to help our horizontal groups to track their review comments:
https://w3c.github.io/horizontal-issue-tracker/

We've been deploying those labels constantly:
https://w3c.github.io/issue-metadata.html#horizontal-reviews

The definition of those labels comes from:
https://w3c.github.io/hr-labels.json

Since our horizontal groups are also providing feedback to the whatwg specs, I wonder if we can deploy those labels to the whatwg spec repos as well (already the case for i18n-* labels).

For example, 3047 is tracked by the privacy folks and it would be nice to add "privacy-tracker" to it.

If the labels get added, the next step to figure out will be how those labels can be added on issues when needed. Ad-hoc is good answer for now I think but open for ideas.

@annevk
Copy link
Member

annevk commented Mar 18, 2020

Yeah, we have similar labels but we can probably deduplicate.

  1. How stable will these names be?
  2. How often do we expect more labels?
  3. Who should I invite for label triage? (We have a team that has the Triage permission so they can set labels on issues and such. Already used for i18n.)
  4. How are symbol/longdesc/repo to be used?

Depending on 1/2 it might be nice to have more information in the JSON resource (is that a stable URL?) so https://github.com/whatwg/meta/blob/master/LABELS.md can have some links in it to the respective groups automatically. (Perhaps a Markdown version of the description.)

@annevk
Copy link
Member

annevk commented Mar 18, 2020

While we're here, does the W3C have an MDN story that would make sense to share? We have an "impacts documentation" label as well as a whatwg/documentation team we try to use as needed.

@plehegar
Copy link
Author

  1. I'd say the labels are pretty stable at this point and aligned among all of our horizontal groups.
  2. we might get 2 more for the TAG. Nothing beyond that at this point. We are spreading labels for errata management but I think it's not relevant for the whatwg. The W3C/WHATWG MOU does mention "custom labels" but I'd say that's outside the scope of this request and would only be applicable for HTML and DOM if any.
  3. I'll come back with a list of github account names for privacy, security and accessibility (and TAG?). Sounds like you're all set for i18n already. You may want to add me temporarily since I've been doing some harmonization to bring everyone up-to-speed.
  4. the broad description of the labels are in the doc I pointed to. We're working on guidance for folks but here is the short version:

*-tracker should be used by anyone (whatwg folks or triage team) to bring any issue to the attention of one of our horizontal groups. Whether the horizontal group chooses to act on it or not is up to them however.

*-needs-resolution should only be used by the triage team to indicate that the horizontal group see the issue as important and expects a resolution. From our side, I'd say this is only relevant to us for the html and dom repositories given the MoU and only if the horizontal group go through the HTML Working Group if they want to escalate the matter. From the whatwg side, I guess it could help with prioritization of issues, if anything.

Issues with *-tracker and *-needs-resolution will automatically show up in the radar after some delay. We don't automatically track a whatwg repository unless an horizontal group asks us to so far (for an example, see i18n config). We could easily track more in our tooling btw (we have a github cache that preloads issues from all repositories for a given set of GH orgs, including the whatwg).

cc @dontcallmedom @r12a

@plehegar
Copy link
Author

On MDN, having a label to help the MDN side sounds like a good idea to me, but I don't know if it helps the MDN folks. @dontcallmedom is our W3C/MDN contact so he would probably be more up to speed on that front.

@dontcallmedom
Copy link

re MDN, we don't have a clear story on this yet - part of this is that MDN is looking into transitioning their content to github, at which point the exact sync workflow will be easier to design and apply.

@plehegar
Copy link
Author

one more point: on the JSON URL, yes, I can commit for it to be stable.

@domenic
Copy link
Member

domenic commented Mar 18, 2020

we have similar labels but we can probably deduplicate.

Just popping by to note I don't see any obvious deduplications here. E.g. our security/privacy should not be merged with privacy-tracker or privacy-needs-resolution since those are PING-specific.

I'm a bit sad about the generic nature of these labels (i.e. using privacy-tracker for something PING specific) but I guess it's not a big deal. We can ameliorate it using label descriptions probably, e.g. adding a W3C: prefix before the description that GitHub shows.

@annevk
Copy link
Member

annevk commented Mar 18, 2020

You think that PING would not want to track all privacy issues? That hasn't been a problem for i18n to date. I'd rather not have to label things twice.

@plehegar
Copy link
Author

fyi, PING is already tracking HTML. See https://github.com/w3cping/tracking-issues/issues?q=is%3Aissue+is%3Aopen+label%3As%3Ahtml
(as a side, PING has been a lot proactive at tracking WICG repos as well btw).

It doesn't hurt to keep the security/privacy label as well btw, if the whatwg editors want to flag some issues without putting them in the PING radar. It may be that PING triage team may elect to track some of those anyway.

I do recognize that we're all struggling in resolving the privacy issues to everyone satisfaction, as I'm sure you're already aware :(

annevk added a commit that referenced this issue Mar 25, 2020
@annevk
Copy link
Member

annevk commented Mar 25, 2020

I put up a PR at #164 that doesn't try to do anything ambitious. It imports the upstream labels, annotates them to make it clear they are from upstream, and also writes them out in the documentation (LABELS.md) accordingly with a link to the W3C horizontal labels documentation.

annevk added a commit that referenced this issue Mar 25, 2020
annevk added a commit that referenced this issue Mar 25, 2020
@annevk
Copy link
Member

annevk commented Mar 25, 2020

@plehegar I've invited you to the triage team. More people can be added. Either via a new issue here, or asking Domenic / Mike / me.

@plehegar
Copy link
Author

Nice. Fyi, we deployed our horizontal-admin, such as https://github.com/orgs/w3c/teams/horizontal-admin . We'll add a tool to keep them in sync. Here is my guideline for those in the horizontal team:
[[
You are part of the triage team since you are involved in horizontal reviews of Web specifications. This means that you may need to add a *-tracker or *-needs-resolution label on any of the issues associated one of the repositories of this team. The full triage of the issues is under the responsibilities of the Groups however so refrain from doing anything else except applying an horizontal label..

Using your participation in the triage team, You MAY only apply an horizontal label to a Group issue, ie one of the *-tracker or *-needs-resolution label.

You MAY NOT re-open an issue in a Group even if the Group chose to close an horizontal issue prematurely.
]]

If someone from the horizontal team is misbehaving, don't hesitate to bring this up.

@annevk
Copy link
Member

annevk commented Mar 25, 2020

Shall I invite those people to the WHATWG triage team?

@plehegar
Copy link
Author

please do. Ideally, all of the people listed in https://github.com/orgs/w3c/teams/horizontal-admin .

I added the privacy-tracker to 2 HTML issues already.

@annevk
Copy link
Member

annevk commented Mar 25, 2020

Great, done.

@plehegar
Copy link
Author

one last thing: can you rename the team to "horizontal-admin"? this would match similar teams in w3c, WICG, etc.

@domenic
Copy link
Member

domenic commented Mar 25, 2020

I think it's OK if different standards groups have different team names.

@annevk
Copy link
Member

annevk commented Mar 25, 2020

The WHATWG team also has a broader purpose. It's basically there to give people the GitHub Triage permission so they can help out with various aspects of standardization.

@plehegar
Copy link
Author

I integrated the TAG last week as part of our horizontal review tracking. We're working on clarifying of what type of issues may be valuable for the TAG but we added the labels "tag-tracker" and "tag-resolution" (see descrtiption and raw definition). For the horizontal team, I added @torgo, @plinss, and @ylafon. Can those labels and 3 individuals be added please?

@annevk
Copy link
Member

annevk commented Apr 22, 2020

#167 and added/invited them. Please create a fresh issue next time. It's easy to forgot about already closed issues.

@plehegar
Copy link
Author

thank you and will create a pull request next time.

@plehegar
Copy link
Author

(actually, I don't expect a next time btw. unless I'm mistaken, we're done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants