Update font types list and sniffing #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
force-pushed
the
font-mime-types
branch
from
ca8744f
to
5d29af7
Compare
LeoColomb
reviewed
Feb 5, 2018
| <li><code>application/font-ttf</code> | ||
| <li><code>application/font-woff</code> | ||
| <li><code>application/vnd.ms-fontobject</code> | ||
| <li><code>application/vnd.ms-opentype</code> |
There was a problem hiding this comment.
@domenic These types are not the ones defined on RFC8081, right? 😸
There was a problem hiding this comment.
Right, but they still need to be treated as font MIME types by software that's using MIME types for any determination of how to deal with a resource.
GPHemsley
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc participants in those threads: @bradleyfalzon @LeoColomb @svgeesus.
There's a separate issue of whether browsers do MIME sniffing for fonts at all, as @annevk has alluded to, but the spec at least seems to imply that they do, so let's make it accurate for now.
Preview | Diff