Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noembed setup scripts #53

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Add noembed setup scripts #53

merged 2 commits into from
Dec 14, 2017

Conversation

foolip
Copy link
Member

@foolip foolip commented Dec 13, 2017

Tested on a fresh Debian VM and appearing to do the right thing, but
not tested end-to-end because of certs.

Fixes #52.

Tested on a fresh Debian VM and appearing to do the right thing, but
not tested end-to-end because of certs.

Fixes #52.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with potential issue


read -p "Copy private-config.sample.json to private-config.json and fill in all the values appropriately. Then press enter to continue"

echo "@reboot cd $PARTICIPATE_DIR && pm2 start -i 4 --name="participate" npm -- start" | sudo -u noderunner crontab -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these quotes need to be escaped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, by good fortune this ended up writing @reboot cd && pm2 start -i 4 --name=participate npm -- start to crontab instead, and that happens to work. I'll just remove the quotes.


read -p "Copy private-config.sample.json to private-config.json and fill in all the values appropriately. Then press enter to continue"

echo "@reboot cd $PARTICIPATE_DIR && pm2 start -i 4 --name="participate" npm -- start" | sudo -u noderunner crontab -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, any thoughts as to whether this is good enough, or if https://futurestud.io/tutorials/pm2-restart-processes-after-system-reboot would be better?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks like pm2 startup systemd should get us hooked up with the init system properly. I think that makes sense, and will file a follow-up issue.

@domenic
Copy link
Member

domenic commented Dec 14, 2017

Note to future self: when we move build.whatwg.org here, we should use https://futurestud.io/tutorials/pm2-advanced-app-configuration-with-json-file to configure multiple apps.

@foolip foolip merged commit f2f2a48 into master Dec 14, 2017
@foolip foolip deleted the noembed branch December 14, 2017 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants