-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date/timestamp field #20
Comments
I don't think we need to worry about timestamps. The main usecase here If the user crosses a timezone line that doesn't affect how long ago / Jonas |
So you think it should be an offset? In milliseconds per what we decided for web animations? Paging @domenic for verification. |
I read @sicking as wanting an absolute point in time. (Timezone-independent.) In that case we would use a timestamp, like that returned by I guess I am assuming "I don't think we need to worry about timestamps" was supposed to be "I don't think we need to worry about timezones." Anyway, yes, we did indeed fix web animations to use milliseconds for offsets, in the event that I am wrong and @sicking wanted offsets. |
What @domenic said. I ment to say to not worry about timezones. And that we So if you want to notify about a meeting happening in 10 minutes, you'd |
Ping? Any reason not to do this? This seems like a simple feature to add, and notifications look really ugly when you get a notification which says "Meeting starting in 10 minutes [8 minutes ago]" where the part inside the [] is rendered by the platform in a different color. |
I guess we should do this, yes. Perhaps @beverloo or @johnmellor wants to create another PR? |
I'm in favor of doing this too, and will prepare a PR tomorrow. Thanks for kicking this up, @sicking! :) |
Fixes whatwg#20. The `timestamp` of a notification is the time, in milliseconds since the epoch, of the event for which the notification was created. Web developers can use this if the time of this event does not match the time at which the notification is being shown, which can be the case when notifying the user of upcoming calendar events.
Fixes whatwg#20. The `timestamp` of a notification is the time, in milliseconds since the epoch, of the event for which the notification was created. Web developers can use this if the time of this event does not match the time at which the notification is being shown, which can be the case when notifying the user of upcoming calendar events.
Fixes whatwg#20. The `timestamp` of a notification is the time, in milliseconds since the epoch, of the event for which the notification was created. Web developers can use this if the time of this event does not match the time at which the notification is being shown, which can be the case when notifying the user of upcoming calendar events.
Fixes whatwg#20. The `timestamp` of a notification is the time, in milliseconds since the epoch, of the event for which the notification was created. Web developers can use this if the time of this event does not match the time at which the notification is being shown, which can be the case when notifying the user of upcoming calendar events.
Fixes whatwg#20. The `timestamp` of a notification is the time, in milliseconds since the epoch, of the event for which the notification was created. Web developers can use this if the time of this event does not match the time at which the notification is being shown, which can be the case when notifying the user of upcoming calendar events.
Fixes whatwg#20. The `timestamp` of a notification is the time, in milliseconds since the epoch, of the event for which the notification was created. Web developers can use this if the time of this event does not match the time at which the notification is being shown, which can be the case when notifying the user of upcoming calendar events.
See http://lists.w3.org/Archives/Public/public-whatwg-archive/2014Aug/0017.html
@sicking, I guess this should just mimic the timestamp used for Date objects? Do we expect applications to worry about timezones?
The text was updated successfully, but these errors were encountered: