Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: adopt more Infra terminology #123

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Editorial: adopt more Infra terminology #123

merged 3 commits into from
Feb 27, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 27, 2018 •
edited by pr-preview bot
Loading

@annevk
Copy link
Member Author

annevk commented Feb 27, 2018

This can land after #122.

@annevk
Editorial: adopt more Infra terminology
810a7b9 
Remove "substeps" and define "list of notifications" as a list and manipulate it as such.
@annevk annevk changed the title Annevk/infra @annevk Editorial: adopt more Infra terminology Feb 27, 2018
@annevk annevk changed the title @annevk Editorial: adopt more Infra terminology Editorial: adopt more Infra terminology Feb 27, 2018
@annevk annevk requested a review from beverloo February 27, 2018 13:47
@annevk annevk mentioned this pull request Feb 27, 2018
Merged
beverloo
beverloo approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@beverloo beverloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I like the clarity the references to the infra spec add :). Thanks!

@annevk annevk merged commit daf4b50 into master Feb 27, 2018
@annevk annevk deleted the annevk/infra branch February 27, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beverloo beverloo beverloo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @beverloo