Updated My Github ID (Aaqa Ishtyaq) #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you have the ID 22131756 before? It appears to be deleted now. I guess since you're not verified yet this kind of modification is probably fine, but I'd like @domenic to double check. |
|
I was a bit confused b/w github id and github username. And I put my id instead of username in the form. |
domenic
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
Thanks. I'll file issues on https://github.com/whatwg/participate.whatwg.org to make this clearer.
domenic
added a commit
to whatwg/participate.whatwg.org
that referenced
this pull request
Aug 21, 2018
In whatwg/participant-data#7, a participant got confused between GitHub "ID" and GitHub "username". We should say username, as that's what GitHub appears to use in most of their UI. The data model still uses "ID", as changing that would be complicated for little benefit. Also changes the confusing field label "Contact (email)" for individuals to just "Email" as is done for entity contacts.
domenic
added a commit
to whatwg/participate.whatwg.org
that referenced
this pull request
Aug 21, 2018
In whatwg/participant-data#7, a participant got confused between GitHub "ID" and GitHub "username". We should say username, as that's what GitHub appears to use in most of their UI. The data model still uses "ID", as changing that would be complicated for little benefit. Also changes the confusing field label "Contact (email)" for individuals to just "Email" as is done for entity contacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@annevk Please check it and verify.