Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PermissionState instead of PersistentStoragePermission #10

Closed
mounirlamouri opened this issue Aug 31, 2015 · 7 comments
Closed

Use PermissionState instead of PersistentStoragePermission #10

mounirlamouri opened this issue Aug 31, 2015 · 7 comments

Comments

@mounirlamouri
Copy link
Member

The spec is re-introducing its own permission enum instead of re-using the one from the Permissions API. It would be great to re-use the Permissions API's PermissionState instead of PersistentStoragePermission.

@domenic
Copy link
Member

domenic commented Aug 31, 2015

As far as I can tell this is an intentional move to align with the existing platform conventions ("default") instead of the new proposal, only implemented in Chrome's Permissions API, of "prompt".

@mounirlamouri
Copy link
Member Author

  • "prompt" is also used by the Push API
  • Permissions API is about to ship in Firefox

@domenic
Copy link
Member

domenic commented Aug 31, 2015

@mounirlamouri
Copy link
Member Author

Mozilla's Intent to Ship do not really work the same way as Blink's. I would be surprised if the API doesn't ship.

@annevk
Copy link
Member

annevk commented Mar 31, 2016

It's a little hard to build on the Permission API if basic stuff like w3c/permissions#33 is not getting fixed. And e.g., the permission store does not take origin as an argument despite entries being associated with one. It doesn't seem to make much sense at the moment.

@annevk annevk closed this as completed in a5ca15e Mar 31, 2016
@sicking
Copy link

sicking commented Mar 31, 2016

To be clear, Firefox is now shipping the permission API.

I don't see it as likely that we would implement the StorageManager.persistentPermission() function since that functionality is better provided through the permission API instead.

I.e. we should not let editorial issues affect what API we use. Ultimately what needs to be defined is what string should be passed to the permission API in order to check permission to use persistent storage. At least until we've gotten the various specs into the needed state to define this formally. I propose using "persistent-storage", but I don't actually care at all what the string is.

@annevk
Copy link
Member

annevk commented Mar 31, 2016

I guess that's fair. Could you file a new issue on that or mention it in #14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants