Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix the reference to "persistent-storage". #122

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented Feb 24, 2021

After w3c/permissions#229 moved it to that spec.

It'll be safe to remove the link-defaults block once Shepherd has scanned the new dfn-less version of this spec.


Preview | Diff

storage.bs Outdated
@@ -447,7 +450,7 @@ as persistent without involvement from the <a for=/>origin</a> or user. This mak
useful for resources the user needs to have available while offline or resources the user creates
locally.

<p>The <dfn for="PermissionName" enum-value>"<code>persistent-storage</code>"</dfn>
<p>The {{"persistent-storage"}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add PermissionName/ in front here and elsewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other request, when doing this, can you put the quotes outside the {{...}} as in "{{...}}". That matches the way we format things better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@annevk annevk merged commit 6395f44 into whatwg:main Feb 26, 2021
@jyasskin jyasskin deleted the update-permission-enum branch February 26, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants