Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check PermissionState instead of PermissionStatus #39

Merged
merged 2 commits into from
Dec 16, 2016
Merged

Check PermissionState instead of PermissionStatus #39

merged 2 commits into from
Dec 16, 2016

Conversation

shuangMoz
Copy link
Contributor

No description provided.

@annevk
Copy link
Member

annevk commented Dec 16, 2016

You want to be changing the .bs resource at all times. The .html resource is generated from it by running make (you don't have to do that for a PR though).

@shuangMoz
Copy link
Contributor Author

Oh, I did not know that.

@annevk
Copy link
Member

annevk commented Dec 16, 2016

https://github.com/whatwg/storage/blob/master/README.md#pull-requests has some guidelines.

@shuangMoz
Copy link
Contributor Author

I'm not sure the commit message is good enough, it seems a trivial fix.

@shuangMoz
Copy link
Contributor Author

I've modified storage.bs.

@annevk annevk merged commit 9c54b3d into whatwg:master Dec 16, 2016
@annevk
Copy link
Member

annevk commented Dec 16, 2016

Thanks!

@shuangMoz
Copy link
Contributor Author

Thank you for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shuangMoz @annevk