Use interface mixins instead of [NoInterfaceObject]
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romandev thanks! Could you please add your name to the list of acknowledgments? |
annevk
approved these changes
Dec 18, 2017
WebIDL recently introduced dedicated syntax for mixins[1]. So, we can replace `[NoInterfaceObject]` and `implements` with `interface mixin` and `includes`. This following interface is impacted by this change: - NavigatorStorage This fixes whatwg#53 issue. [1] whatwg/webidl@45e8173
romandev
force-pushed
the
mixin_storage
branch
from
14a891c
to
9e79239
Compare
|
@annevk Gentle ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebIDL recently introduced dedicated syntax for mixins[1]. So, we can
replace
[NoInterfaceObject]andimplementswithinterface mixinandincludes.This following interface is impacted by this change:
This fixes #53 issue.
Test: web-platform-tests/wpt#8702
[1] whatwg/webidl@45e8173
Preview | Diff