Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDNA: realign once UTS46 revision 18 is final #313

Closed
annevk opened this issue May 24, 2017 · 2 comments
Closed

IDNA: realign once UTS46 revision 18 is final #313

annevk opened this issue May 24, 2017 · 2 comments
Labels
topic: idna topic: parser

Comments

@annevk
Copy link
Member

annevk commented May 24, 2017

web-platform-tests: url/toascii.json.

This is a tracking issue to make sure we align with UTS46 if there are further changes to it. And if there are no further changes to it we need to at least update the links and remove the issue marker.
annevk added a commit that referenced this issue May 24, 2017
@annevk
IDNA: use proposed UTS46 flags to avoid breaking YouTube
d31cef7 
Fixes #53 and fixes #267 by no longer breaking on on hyphens in the
3rd and 4th position of a domain label. This is known to break
YouTube: r3---sn-2gb7ln7k.googlevideo.com. This is done by setting
the proposed CheckHyphens flag to false.

Fixes #110 by clarifying that BIDI and CONTEXTJ checks are to be done
by setting the proposed CheckBidi and CheckJoiners flags to true.

Follow-up #313 is filed to remove the proposed bits once Unicode is
updated.
annevk added a commit that referenced this issue May 24, 2017
@annevk
IDNA: use proposed UTS46 flags to avoid breaking YouTube
27ee1aa 
Tests: web-platform-tests/wpt#5976.

Fixes #53 and fixes #267 by no longer breaking on on hyphens in the
3rd and 4th position of a domain label. This is known to break
YouTube: r3---sn-2gb7ln7k.googlevideo.com. This is done by setting
the proposed CheckHyphens flag to false.

Fixes #110 by clarifying that BIDI and CONTEXTJ checks are to be done
by setting the proposed CheckBidi and CheckJoiners flags to true.

Follow-up #313 is filed to remove the proposed bits once Unicode is
updated.
domenic pushed a commit that referenced this issue Jun 1, 2017
@annevk @domenic
IDNA: use proposed UTS46 flags to avoid breaking YouTube
dc9d831 
Tests: web-platform-tests/wpt#5976.

Fixes #53 and fixes #267 by no longer breaking on hyphens in the 3rd and
4th position of a domain label. This is known to break YouTube:
r3---sn-2gb7ln7k.googlevideo.com. This is fixed by setting the proposed
CheckHyphens flag to false.

Fixes #110 by clarifying that BIDI and CONTEXTJ checks are to be done
by setting the proposed CheckBidi and CheckJoiners flags to true.

Follow-up #313 is filed to remove the proposed bits once Unicode is
updated. #317 also tracks a potential cleanup.
@domenic
Copy link
Member

domenic commented Jun 20, 2017 •
edited

http://www.unicode.org/reports/tr46/tr46-19.html is released and announced, although http://www.unicode.org/reports/tr46/ still points to v9 instead of v10. Maybe that update will roll out sometime later today.

Edit: it rolled out.

annevk added a commit that referenced this issue Jun 22, 2017
@annevk
IDNA: UTS46 revision 19 is part of Unicode 10
abf9211 
It appears identical to the earlier proposed revision 18 for the
purposes of the URL Standard.

Fixes #313.
@annevk annevk mentioned this issue Jun 22, 2017
Merged
annevk added a commit that referenced this issue Jun 22, 2017
@annevk
IDNA: UTS46 revision 19 is part of Unicode 10
b128ba9 
It appears identical to the earlier proposed revision 18 for the
purposes of the URL Standard.

Fixes #313.
@rjkmurray
Copy link

You know I had it figured out and all my research is for nothing. I hope at least the government can use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: idna topic: parser
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @annevk @rjkmurray