Remove Googlefight links #352
Conversation
|
Thank you and apologies for following up late. Perhaps instead of removing the reference altogether, we could instead use |
|
@annevk You do not have to apologize: you do not owe me anything! A trend URL would work nicely! |
url.bs
Outdated
| not helping anyone. | ||
| An even if this a weak argument, URL also easily wins | ||
| <a href="https://trends.google.com/trends/explore?q=url,uri"> | ||
| search result popularity contest</a> |
There was a problem hiding this comment.
I prefer keeping the old text. I don't think it's a weak argument per se. When having to chose between two terms using the one that's most popular is rather good practice as it requires the least amount of people to change habits.
And there's also no wrapping inside an inline element.
url.bs
Outdated
| <a href="http://www.googlefight.com/index.php?word1=url&word2=uri">search result popularity contest</a>. | ||
|
|
||
| not helping anyone. URL also easily wins <a href="https://trends.google.com/trends/explore?q=url,uri"> | ||
| search result popularity contest</a> |
There was a problem hiding this comment.
It seems you dropped "the" and the period at the end. The original formatting of <a> on a new line and no newlines inside it was also correct. Otherwise the contents of the element start with a newline.
|
And before I forget, please add yourself to the acknowledgments section. We like to acknowledge all contributions. |
|
Let me fix and squash this cleanly too. |
|
It's fine to just post follow-up commits. I'll clean it up through GitHub's UI when landing. |
The Googlefight web site does not work anymore. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
@annevk ready to merge :) Thanks for the review! |
|
Thank you! |
The web site does not work anymore.
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com
Preview | Diff