Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch maplike/setlike to use infra maps and sets #1138

Merged
merged 18 commits into from May 5, 2022
Merged

Switch maplike/setlike to use infra maps and sets #1138

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ea2475e
WIP: switching maplike/setlike to use infra maps and sets
tabatkins Apr 29, 2022
274dedc
WIP: Switched iterators over to use the infra map/set
tabatkins May 2, 2022
165b181
WIP: Switch forEach to directly use infra
tabatkins May 2, 2022
2b10a30
WIP: Just rely on infra iteration (tbd)
tabatkins May 2, 2022
415c220
WIP: Convert all the Map methods to use bespoke infra-based functiona…
tabatkins May 2, 2022
4cb8dd6
WIP: Switch set methods to use infra sets
tabatkins May 3, 2022
03f9211
Align the order of map and set methods
tabatkins May 3, 2022
ba9d146
Move @@iterator/forEach into the map and set methods section
tabatkins May 3, 2022
6f92dac
Rename to 'implementation check', use more descriptive argument name,…
tabatkins May 3, 2022
a4d01b8
Use correct markup for passing strings
tabatkins May 3, 2022
0da6bce
Silence the var warnings
tabatkins May 3, 2022
2c7039a
[editorial] 'an entries'
tabatkins May 3, 2022
34220e3
Specify guidance for how specs should implement set/delete/etc
tabatkins May 3, 2022
ee646c0
[editorial] an->a
tabatkins May 3, 2022
c588a93
Add the final old ids back
tabatkins May 3, 2022
f785465
Escape urls properly (uh, this implies a bikeshed bug)
tabatkins May 3, 2022
124f557
address feedback
tabatkins May 3, 2022
2cb3b55
[editorial] review fixes
tabatkins May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.bs
View file
Open in desktop
Expand Up @@ -12885,7 +12885,7 @@ with the following characteristics:
The value of the [=function object=]’s <code class="idl">name</code> property is the String value "<code>size</code>".


<h5 id="es-map-iterator">@@iterator</h5>
<h5 id="es-map-iterator" oldids="es-iterator, es-iterators">@@iterator</h5>

There must exist a data property whose name is the {{@@iterator}} symbol on
|A|’s [=interface prototype object=]
Expand Down Expand Up @@ -12977,7 +12977,7 @@ The value of the [=function objects=]’ <code class="idl">length</code> propert
The value of the [=function object=]’s <code class="idl">name</code> property is the String value "<code>values</code>".


<h5 id="es-map-forEach">forEach</h5>
<h5 id="es-map-forEach" oldids="es-forEach">forEach</h5>

There must exist a <code class="idl">forEach</code> data property on
|A|’s [=interface prototype object=]
Expand Down