Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Refer to ECMA-262 as JavaScript rather than ECMAScript #1379

Merged
merged 14 commits into from
Dec 28, 2023

Conversation

jeremyroman
Copy link
Contributor

@jeremyroman jeremyroman commented Dec 19, 2023

This is consistent with how the HTML Living Standard, also a a WHATWG work product, refers to it and is how most developers would be familiar with it.

Included in this change:

  • a note about this convention
  • renaming various algorithms and sections (and adding aliases for pre-existing IDs)
  • renaming variables and other things which refer to ECMAScript in an abbreviation

Fixes #863.


Preview | Diff

@jeremyroman
Copy link
Contributor Author

@annevk @domenic PTAL? I'm hopeful that preserving most of the IDs as old IDs (or replicating the effect of oldids by using the same trick of adding empty spans, for cases where that's not supported by Bikeshed) will minimize the disruption to other specs.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @jeremyroman!

index.bs Outdated
@@ -1533,7 +1535,7 @@ on which they appear. It is language binding specific whether
};
</pre>

the constant value can be accessed in ECMAScript either as
the constant value can be accessed in JavaScript either as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the constant value can be accessed in JavaScript either as
the constant value can be accessed in JavaScript either as

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -6964,11 +6967,11 @@ to its caller, and so on.
</div>


<h3 id="es-environment">ECMAScript environment</h3>
<h3 id="js-environment" oldids="es-environment">JavaScript environment</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping the old IDs and not adding new IDs would be fine as well. I personally prefer that as it shows the document has some history.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some history of using oldids (e.g., adding es-undefined and adding es-void as an old ID, when WebIDL renamed the concept of void). If the consensus is that we should continue to use es- for IDs then I can unwind that, though.

@annevk
Copy link
Member

annevk commented Dec 21, 2023

We should add "Fixes #863." to the end of the final commit message. (Seems PR Preview won the race a couple times there.)

@annevk annevk merged commit 8920a62 into whatwg:main Dec 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Editorial: align with HTML on calling ECMAScript JavaScript
2 participants