Change the named property visibility algorithm so that existing own props always make corresponding named props invisible. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 1. If |O| has an own property named |P|, then return false. | ||
| <div class="note"> | ||
| Note that this will include cases in which an object has unforgeable properties, because in practice those are always set up before objects have any supported property names, and once set up will make the corresponding named properties invisible. | ||
| </div> |
There was a problem hiding this comment.
These three lines can be replaced with Note: This will include....
bzbarsky
force-pushed
the
reorder-named-props-and-own
branch
from
cf3530f
to
f2da81e
Compare
|
(In a few meetings, will look at the substantive stuff in an hour or two...) |
|
@yuki3, @cdumez, @travisleithead, any remaining concerns here? |
|
This LGTM. It might be worth adding a note in the commit message that this fixes #152 by choosing option (1). |
Will do. |
bzbarsky
force-pushed
the
reorder-named-props-and-own
branch
from
f2da81e
to
3bba149
Compare
…rops always make corresponding named props invisible. Fixes <whatwg#152> by picking option (1).
bzbarsky
force-pushed
the
reorder-named-props-and-own
branch
from
3bba149
to
c7042eb
Compare
|
I have no concern here. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152.