Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various follow-up fixes to #180. #192

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Various follow-up fixes to #180. #192

merged 1 commit into from
Oct 18, 2016

Conversation

tobie
Copy link
Collaborator

@tobie tobie commented Oct 17, 2016

Fix distinguishable algorithm. Closes #190.
Fix record handling in various algorithms. Closes #191, closes #189.


Preview (#dfn-disti…) (#es-union) (#es-overlo…) | Diff (#dfn-disti…) (#es-union) (#es-overlo…)

Fix distinguishable algorithm. Closes whatwg#190.
Fix record handling in various algorithms. Closes whatwg#191, closes whatwg#189.
@tobie
Copy link
Collaborator Author

tobie commented Oct 17, 2016

/cc @bzbarsky @domenic @jyasskin

@@ -3253,7 +3253,7 @@ extended attribute’s [=takes a named argument list|named argument list=].
</div>

Two types are <dfn id="dfn-distinguishable" export>distinguishable</dfn> if
at most one of the two [=includes a nullable type=]
at most one of the two [=includes a nullable type=], is a [=dictionary type=], or a [=record type=],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still somewhat ambiguous in the way that confused me in the first place. I don't see a simple way to fix that, but I've started a patch in gh-pages...jyasskin:dictionary-distinguishability to try to make it clearer. I'll try to send a PR for that tomorrow, but feel free to steal it instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. @bzbarsky wanted to avoid leaving a broken spec out for too long, though. Hence the quick fix. Disambiguation can wait for a follow-up PR. Although examples are super useful, I don't think they're appropriate to disambiguate normative statements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think examples are good for disambiguating normative statements, although of course if you can make the phrasing itself less confusing that's good too. See e.g. whatwg/html#1874

@tobie tobie merged commit 40d03aa into whatwg:gh-pages Oct 18, 2016
@tobie tobie deleted the fix-180 branch October 18, 2016 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants