Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow records to be nullable in all cases and omitted as optional operation arguments. #305

Merged
merged 1 commit into from Feb 13, 2017

Conversation

bzbarsky
Copy link
Collaborator

@bzbarsky bzbarsky commented Feb 11, 2017

Basically, make record<> more like sequence<> than like dictionary in terms of things that can be converted to it (without the requirement for iterability, of course)


Preview | Diff

…ration arguments.

Basically, make record<> more like sequence<> than like dictionary in terms of things that can be converted to it (without the requirement for iterability, of course)
@bzbarsky
Copy link
Collaborator Author

Fixes whatwg/fetch#479 and is an updated version of #304

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes LGTM. But, should the distinguishability categories also be updated to move record from "dictionary-like" to "sequence-like"?

@bzbarsky
Copy link
Collaborator Author

But, should the distinguishability categories also be updated to move record from "dictionary-like" to "sequence-like"?

Good question! I stopped on that too, when reading this. The answer is "no". That's because for distinguishability categories "sequence-like" means "iterable thing" and "dictionary-like" means "some random object". I mean, "callback interfaces" are "dictionary-like"....

@bzbarsky bzbarsky merged commit 9af88fa into whatwg:gh-pages Feb 13, 2017
triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this pull request Feb 14, 2017
TimothyGu added a commit to TimothyGu/webidl2js that referenced this pull request May 8, 2017
domenic pushed a commit to jsdom/webidl2js that referenced this pull request May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants