Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async and includes as member names #769

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Allow async and includes as member names #769

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
015739e
Allow `async` and `includes` as member names
saschanaz Aug 12, 2019
15108de
Allow "async" as a valid argument name
saschanaz Aug 13, 2019
68aa41d
OptionalOperationName
saschanaz Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 14 additions & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ underscore.

<pre class="grammar" id="prod-ArgumentNameKeyword">
ArgumentNameKeyword :
"async"
"attribute"
"callback"
"const"
Expand Down Expand Up @@ -1976,6 +1977,7 @@ are applicable only to regular attributes:

<pre class="grammar" id="prod-AttributeNameKeyword">
AttributeNameKeyword :
"async"
"required"
</pre>

Expand Down Expand Up @@ -2425,10 +2427,21 @@ The following extended attributes are applicable to operations:

<pre class="grammar" id="prod-OptionalIdentifier">
OptionalIdentifier :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename this to OptionalOperationName, right?

identifier
OperationName
ε
</pre>

<pre class="grammar" id="prod-OperationName">
OperationName :
OperationNameKeyword
identifier
</pre>

<pre class="grammar" id="prod-OperationNameKeyword">
OperationNameKeyword :
"includes"
</pre>

<pre class="grammar" id="prod-ArgumentList">
ArgumentList :
Argument Arguments
Expand Down