Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the observable array type (proxy-based) #840

Merged
merged 12 commits into from Mar 18, 2020
Merged

Introduce the observable array type (proxy-based) #840

merged 12 commits into from Mar 18, 2020

Commits on Feb 3, 2020

  1. Introduce the observable array type (proxy-based) 

    Part of #796.
    @domenic
    domenic committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    8dda4ad View commit details
    Browse the repository at this point in the history

  2. Ensure there are no holes in the array

    @domenic
    domenic committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    18fa303 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Code review comments

    @domenic
    domenic committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    a613257 View commit details
    Browse the repository at this point in the history

  2. Touchups

    @domenic
    domenic committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    433face View commit details
    Browse the repository at this point in the history

  3. Track the backing list 

    This is kind of suboptimal because spec authors must not modify it. Adding more traps would let us do this better.
    @domenic
    domenic committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    d3cc626 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Add all the traps

    @domenic
    domenic committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    119cec7 View commit details
    Browse the repository at this point in the history

  2. "whose values are" plus index param code review comments

    @domenic
    domenic committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    eb3960a View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Review comments from Timothy

    @domenic
    domenic committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    152372f View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Easy review comments

    @domenic
    domenic committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    d8d5bec View commit details
    Browse the repository at this point in the history

  2. Forgot to commit this easy review comment

    @domenic
    domenic committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    77686bb View commit details
    Browse the repository at this point in the history

  3. Fix defineProperty with no [[Value]] to no-op

    @domenic
    domenic committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    85c0e54 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Swap the equal variables

    @domenic
    domenic committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    7c3be07 View commit details
    Browse the repository at this point in the history