Update obsolete note on duplicate Proxy [[OwnPropertyKeys]] entries #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, this can happen with So, the note should be:
|
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
shvaikalesh
force-pushed
the
remove-obsolete-proxy-keys-note
branch
from
e1734b9
to
ec9e010
Compare
shvaikalesh
changed the title
TimothyGu
approved these changes
Oct 16, 2020
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 16, 2023
The comment states that duplicate key names can occur due to a proxy object, but it doesn't appear to be the case as of current ES262 --- [[OwnPropertyKeys]] for objects is guaranteed not to have duplicates: https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys (See steps 9, 13, and the invariants note afterwards) Instead, switch the comment to talk about the case the WebIDL spec mentions --- USVString keys with unmatched surrogates. (This follows a 2020 change to WebIDL: whatwg/webidl#925, which follows a 2017 change to the language). Change-Id: Ifb2bff0ca548d1a6a9d278d51eca8e204a522e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780986 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#1184129}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The note was added in #180, a few months before tc39/ecma262#833 was merged.
cc @domenic @bzbarsky
Preview | Diff