Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n.whatwg.org issues #84

Closed
2 tasks done
annevk opened this issue Sep 2, 2017 · 9 comments
Closed
2 tasks done

n.whatwg.org issues #84

annevk opened this issue Sep 2, 2017 · 9 comments

Comments

@annevk
Copy link
Member

annevk commented Sep 2, 2017

  • The formdata resource is no longer rendered as text/plain.
  • The Index listing has ../ as an item.
@foolip
Copy link
Member

foolip commented Sep 3, 2017

@sideshowbarker

@annevk
Copy link
Member Author

annevk commented Sep 7, 2017

Is the ../ some kind of nginx-style? Also, what's up with not being able to generate valid HTML in 2017 for these kind of indexes?

sideshowbarker added a commit to whatwg/misc-server that referenced this issue Sep 12, 2017
Among other things this change eliminates the problem with nginx showing
`../` in index/directory listings.

Addresses whatwg/whatwg.org#84
sideshowbarker added a commit to whatwg/misc-server that referenced this issue Sep 12, 2017
Among other things this change eliminates the problem with nginx showing
`../` in index/directory listings.

Addresses whatwg/whatwg.org#84
@sideshowbarker
Copy link
Contributor

sideshowbarker commented Sep 12, 2017

Is the ../ some kind of nginx-style?

It’s the style we get from the default autoindex. But there’s an optional fancyindex we can enable that suppresses the ../ (and that makes the listings interactively sortable).

Also, what's up with not being able to generate valid HTML in 2017 for these kind of indexes?

Indeed. I guess I’ll do a PR against the nginx sources (and the fancyindex sources to, since it has the same problem) to make it generate valid HTML for indexes.

Anyway, I have fancyindex (whatwg/misc-server#14) enabled now, so you can go to, e.g., https://n.whatwg.org/ and https://images.whatwg.org/ and https://resources.whatwg.org/ to see what it looks like.

@annevk
Copy link
Member Author

annevk commented Sep 12, 2017

Looks a little ugly, but not objectionably so.

@annevk
Copy link
Member Author

annevk commented Sep 12, 2017

(Oh, and thanks for looking into this!)

@domenic
Copy link
Member

domenic commented Sep 12, 2017

That's way nicer than Apache :). With some extra configuration we could even add our own CSS to make it WHATWG green instead of brown!

@sideshowbarker
Copy link
Contributor

With some extra configuration we could even add our own CSS to make it WHATWG green instead of brown!

Indeed. Raised whatwg/resources.whatwg.org#64 so we don’t forget

@sideshowbarker
Copy link
Contributor

Also, what's up with not being able to generate valid HTML in 2017 for these kind of indexes?

Indeed. I guess I’ll do a PR against the nginx sources (and the fancyindex sources to, since it has the same problem) to make it generate valid HTML for indexes.

Happy to discover that this has already been fixed for fancyindex upstream:

…released only 25 days ago, so we’ll just need to wait for the Debian package to get updated.

sideshowbarker added a commit to whatwg/misc-server that referenced this issue Sep 13, 2017
Among other things this change eliminates the problem with nginx showing
`../` in index/directory listings.

Addresses whatwg/whatwg.org#84
@annevk
Copy link
Member Author

annevk commented Jan 6, 2018

This was fixed by whatwg/misc-server@3d3e364.

@annevk annevk closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants