Use *-snapshot.svg logos for Commit Snapshots #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A variant of this worked locally, but haven't tested this yet. Reasonable approach or should we pass this information into Bikeshed somehow? |
|
It's not terrible, but I think it'd be better to do this similar to how we do RDs, which is https://github.com/tabatkins/bikeshed/blob/master/bikeshed/boilerplate/whatwg/computed-metadata-RD.include . It might be as simple as adding (Side note: I think we could clean up a good amount of the snapshot infrastructure using similar computed metadata techniques that make it similar to RDs. whatwg.org/resources.whatwg.org/build/deploy.sh Lines 106 to 110 in 75b4d97 -F md-status=LS-COMMIT -F md-Text-Macro="SHA $SHA".)
|
sideshowbarker
approved these changes
Mar 18, 2020
annevk
added a commit
that referenced
this pull request
Mar 27, 2020
They will now use a title aligned with Review Drafts, use the snapshot logo, and generally include less data that is best looked for in the Living Standard. Depends upon speced/bikeshed#1635. Closes whatwg/meta#88. Closes #309.
annevk
added a commit
that referenced
this pull request
Apr 6, 2020
Buids upon speced/bikeshed#1635. Remaining work tracked by whatwg/spec-factory#5. Closes whatwg/meta#88. Closes #309. Co-authored-by: Domenic Denicola <d@domenic.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes whatwg/meta#88.