Fix PNG logo colors #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the previous conversions were done with some sort of color setting which changed the output colors. This fixes them, and also adds a PNG version for compat.
|
I cannot see the difference. Is this some color profile thing? |
|
Yes, it must be. On my screen on Firefox and Chrome the "before" is (86, 118, 6) whereas the "after" is (60, 121, 10) i.e. WHATWG green. |
|
I'm not sure this really fixes it. On macOS I don't see a difference between before/after across browsers, but I do see (using Digital Color Meter): Firefox: 60, 121, 10 |
|
Hmm, I don't have macOS available, so I can't really help with that. Maybe we can merge this for now to improve Windows users, and try to fix macOS later? |
annevk
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the previous conversions were done with some sort of color setting which changed the output colors. This fixes them, and also adds a PNG version for compat.
Discovered in whatwg/meta#28 (comment).