Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the filename argument to FormData.append(name, blob) #25

Closed
foolip opened this issue Sep 15, 2015 · 2 comments
Closed

Restore the filename argument to FormData.append(name, blob) #25

foolip opened this issue Sep 15, 2015 · 2 comments

Comments

@foolip
Copy link
Member

foolip commented Sep 15, 2015

Context: https://bugzilla.mozilla.org/show_bug.cgi?id=1162658

I would propose this IDL:

void append(USVString name, Blob value, optional USVString filename);
void append(USVString name, USVString value);

(This is what Blink does.)

@foolip
Copy link
Member Author

foolip commented Dec 2, 2015

@annevk, thoughts? I stumbled across this again now because the Blob is effectively nullable in Blink now, which I'd like to fix, but it matters what happens to this issue. As the spec is written append('', null, '') would stringify the value to "null" I think, but if I make the change I want in Blink it'd instead throw a TypeError as three arguments makes it try the Blob variant. Maybe this is just another bug on Blink's part, but in any case it'd be nice to know how this will end up in the spec.

@annevk annevk closed this as completed in b0ec31e Dec 15, 2015
@foolip
Copy link
Member Author

foolip commented Dec 15, 2015

Thanks, the fix looks good, I'll try to implement that in Blink when I have some spare time.

@foolip foolip changed the title Resture the filename argument to FormData.append(name, blob) Restore the filename argument to FormData.append(name, blob) Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant