Don't fire "progress" event for sync XHR #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fire a "progress" event during "handle response end-of-body" for asynchronous XHR. This matches existing browser behaviour. Test at web-platform-tests/wpt#10887. Closes whatwg#207.
|
Apart from Firefox, right? |
|
Firefox seems to be consistently passing the test I wrote, so its compatible, I guess? When I tested it before I was using the developer console, which can have odd side effects. Edit: The test was wrong. Having updated the test, Firefox consistently passes on the main thread and fails in a worker. I didn't test workers earlier, so I can imagine some other browsers might have the same issue. |
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
May 8, 2018
|
Thanks! |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 16, 2018
…vent, a=testonly Automatic update from web-platform-testsXHR: sync XMLHttpRequest does not fire an event named progress For whatwg/xhr#208. -- wpt-commits: 10f586a6d2f606b86310ba05da18ed13a78c67f4 wpt-pr: 10887
mcmanus
pushed a commit
to mcmanus/gecko
that referenced
this pull request
May 17, 2018
…vent, a=testonly Automatic update from web-platform-testsXHR: sync XMLHttpRequest does not fire an event named progress For whatwg/xhr#208. -- wpt-commits: 10f586a6d2f606b86310ba05da18ed13a78c67f4 wpt-pr: 10887
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…vent, a=testonly Automatic update from web-platform-testsXHR: sync XMLHttpRequest does not fire an event named progress For whatwg/xhr#208. -- wpt-commits: 10f586a6d2f606b86310ba05da18ed13a78c67f4 wpt-pr: 10887 UltraBlame original commit: 816d4ef0a3dea89726812659ab06b401a4d7f94e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…vent, a=testonly Automatic update from web-platform-testsXHR: sync XMLHttpRequest does not fire an event named progress For whatwg/xhr#208. -- wpt-commits: 10f586a6d2f606b86310ba05da18ed13a78c67f4 wpt-pr: 10887 UltraBlame original commit: 816d4ef0a3dea89726812659ab06b401a4d7f94e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…vent, a=testonly Automatic update from web-platform-testsXHR: sync XMLHttpRequest does not fire an event named progress For whatwg/xhr#208. -- wpt-commits: 10f586a6d2f606b86310ba05da18ed13a78c67f4 wpt-pr: 10887 UltraBlame original commit: 816d4ef0a3dea89726812659ab06b401a4d7f94e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fire a "progress" event during "handle response end-of-body" for
asynchronous XHR. This matches existing browser behaviour.
Test at web-platform-tests/wpt#10887.
Closes #207.
Preview | Diff