Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify target of progress events #246

Merged
merged 9 commits into from May 11, 2019
Merged

Specify target of progress events #246

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bcd732b
Specify target of progress events
jugglinmike Apr 17, 2019
b0f1e0e
fixup! Specify target of progress events
jugglinmike Apr 18, 2019
3900e65
fixup! Specify target of progress events
jugglinmike Apr 18, 2019
eb2ee75
fixup! Specify target of progress events
jugglinmike Apr 23, 2019
9030ffc
Editorial: consistently use `this` keyword
jugglinmike Apr 23, 2019
3c0483c
Editorial: Correct preposition
jugglinmike Apr 23, 2019
93add32
fixup! Specify target of progress events
jugglinmike Apr 24, 2019
f78b4dd
fixup! Specify target of progress events
jugglinmike May 3, 2019
05b25a5
fixup! Specify target of progress events
jugglinmike May 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions xhr.bs
View file
Open in desktop
Expand Up @@ -809,7 +809,7 @@ method must run these steps:
<p>If the <a>synchronous flag</a> is unset, then:

<ol>
<li><p><a>Fire a progress event</a> named <a event><code>loadstart</code></a> with 0 and 0.
<li><p><a>Fire a progress event</a> named <a event><code>loadstart</code></a> at [=this=] with 0 and 0.
annevk marked this conversation as resolved.
Show resolved Hide resolved

<li><p>If the <a>upload complete flag</a> is unset and <a>upload listener flag</a> is
set, then <a>fire a progress event</a> named
Expand Down Expand Up @@ -957,7 +957,7 @@ method must run these steps:
<a>state</a> changes.

<li><p><a>Fire a progress event</a> named
<a event><code>progress</code></a> with <var>response</var>'s
<a event><code>progress</code></a> at [=this=] with <var>response</var>'s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended target isn't clear in context. Firefox, Chrome, Edge, and Safari all fire this event at the request object.

<a for=response>body</a>'s
<a>transmitted bytes</a> and
<var>response</var>'s <a for=response>body</a>'s
Expand Down Expand Up @@ -1039,7 +1039,7 @@ method must run these steps:
<a for=body>total bytes</a>.

<li><p>If the <a>synchronous flag</a> is unset, <a>fire a progress event</a> named
<a event><code>progress</code></a> with <var>transmitted</var> and <var>length</var>.
<a event><code>progress</code></a> at [=this=] with <var>transmitted</var> and <var>length</var>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended target isn't clear in context. Firefox, Chrome, Edge, and Safari all fire this event at the request object.


<li><p>Set <a>state</a> to <i>done</i>.

Expand All @@ -1048,9 +1048,11 @@ method must run these steps:
<li><p><a>Fire an event</a> named <a event><code>readystatechange</code></a>.

<li><p><a>Fire a progress event</a> named <a event><code>load</code></a>
at [=this=]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended target isn't clear in context. Firefox, Chrome, Edge, and Safari all fire this event at the request object.

with <var>transmitted</var> and <var>length</var>.

<li><p><a>Fire a progress event</a> named <a event><code>loadend</code></a>
at [=this=]'s {{XMLHttpRequestUpload}} object
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intended target isn't clear in context. Firefox, Chrome, Edge, and Safari all fire this event at the request upload object.

with <var>transmitted</var> and <var>length</var>.
</ol>

Expand Down Expand Up @@ -1122,10 +1124,10 @@ exception <var>exception</var> are:
</ol>

<li><p><a>Fire a progress event</a> named
<var>event</var> with 0 and 0.
<var>event</var> at [=this=] with 0 and 0.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a corresponding event is fired at the request upload object in the previous step, I'm fairly certain the intended target here is the request object.


<li><p><a>Fire a progress event</a> named
<a event><code>loadend</code></a> with 0 and 0.
<a event><code>loadend</code></a> at [=this=] with 0 and 0.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a corresponding event is fired at the request upload object in the previous step, I'm fairly certain the intended target here is the request object.

</ol>


Expand Down