Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: link Review Draft #291

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Meta: link Review Draft #291

merged 2 commits into from
Sep 30, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 29, 2020 •
edited by pr-preview bot

@annevk annevk mentioned this pull request Sep 29, 2020
Closed
@annevk
Copy link
Member Author

annevk commented Sep 29, 2020

@domenic what's the way to read a chunk these days?

@domenic
Copy link
Member

domenic commented Sep 29, 2020

Sorry for missing this update. You use https://streams.spec.whatwg.org/#readablestreamdefaultreader-read-a-chunk, in particular constructing a read request. I'm happy to send a PR if you'd prefer; I meant to fix all the specs but missed this one.

@annevk
Copy link
Member Author

annevk commented Sep 29, 2020

That'd be great, I'll review and land it tomorrow as well as this.

@annevk annevk merged commit 64f56c5 into master Sep 30, 2020
@annevk annevk deleted the annevk/rd-link branch September 30, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annevk @domenic