Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Timing integration #319

Merged
merged 13 commits into from
Feb 11, 2022
Merged

Resource Timing integration #319

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3e39694
WIP: Resource Timing integration
noamr Mar 17, 2021
4dc3e59
Move report timing for error handling
noamr Mar 18, 2021
84d4776
Fix PR nits
noamr Mar 22, 2021
b64447c
Fix extra /OL
noamr Mar 23, 2021
2902875
Style fix
noamr Mar 24, 2021
a2c3974
Reference the actual FETCH/RT dfn
noamr Mar 25, 2021
3ab077a
Fix line sizes
noamr Mar 25, 2021
5d6c993
Update xhr.bs
annevk Mar 25, 2021
a14f102
no need for additional id
annevk Mar 25, 2021
23490db
Report correctly for network errors
noamr Dec 14, 2021
0b6b341
Make sure we don't report timeouts
noamr Dec 14, 2021
3abf8c9
/for/with/
noamr Feb 9, 2022
37ebd4b
nit
annevk Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions xhr.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,6 +954,10 @@ return <a>this</a>'s <a>cross-origin credentials</a>.
</ol>
</ol>

<p>To <dfn>report timing</dfn> for an {{XMLHttpRequest}} object <var>xhr</var>,
<a for=/>finalize and report timing</a> with <var>xhr</var>'s <a for=XMLHttpRequest>response</a>,
<var>xhr</var>'s <a>relevant global object</a>, and "<code>xmlhttprequest</code>".

<p id=handle-response-end-of-file>To <dfn>handle response end-of-body</dfn> for an
{{XMLHttpRequest}} object <var>xhr</var>, run these steps:

Expand All @@ -963,6 +967,8 @@ return <a>this</a>'s <a>cross-origin credentials</a>.
<li><p>If <var>xhr</var>'s <a for=XMLHttpRequest>response</a> is a <a>network error</a>, then
return.

<li><p><a for=/>Report timing</a> for <var>xhr</var>.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this to line 966, and avoid calling report timing from 2 different places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because handle errors needs to report errors only in certain conditions + we need to report it if there are no errors. So there will always be two places

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me we could move this up if we make it conditional upon the timed out flag? (And in the future perhaps the timed out flag can be replaced by using an aborted network error.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it wouldn't work because handle errors is also called from processBodyError, in which case the processEndOfBody callback will not be reached at all. We've been through this in early iterations of this PR


<li><p>Let <var>transmitted</var> be <var>xhr</var>'s <a>received bytes</a>'s
<a for="byte sequence">length</a>.

Expand Down Expand Up @@ -1001,9 +1007,16 @@ return <a>this</a>'s <a>cross-origin credentials</a>.
<a for=response>aborted flag</a> is set, run the <a>request error steps</a> for <var>xhr</var>,
<a event><code>abort</code></a>, and "{{AbortError!!exception}}" {{DOMException}}.

<li><p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a>'s is a
<a for=/>network error</a>, run the <a>request error steps</a> for <var>xhr</var>,
<a event><code>error</code></a>, and "{{NetworkError!!exception}}" {{DOMException}}.
<li>
<p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a> is a
<a for=/>network error</a>, then:

<ol>
<li><p><a for=/>Report timing</a> for <var>xhr</var>.

<li><p>Run the <a>request error steps</a> for <var>xhr</var>,
<a event><code>error</code></a>, and "{{NetworkError!!exception}}" {{DOMException}}.
</ol>
</ol>

<p>The <dfn>request error steps</dfn> for an {{XMLHttpRequest}} object <var>xhr</var>,
Expand Down