-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the color of airline #26
Change the color of airline #26
Conversation
I took another look and see your using a different color in the light line colorscheme. Don't merge this yet It's probably better to use the same colors in both colorschemes. I'll have a look at the differences. |
@alexanderjeurissen hey, thanks for the contribution (thorough as always 😃). A couple of thoughts:
|
I've tried it for some days now and I find the text quite readable I could lighten it a bit though as I've currently used
I agree with the fact that dark text is more readable on the yellow. However the point about not being in insert mode, the same can be said about visual mode because most actions where visual mode is used can be done using text-objects or using relative line numbers. That being said the other colors feel quite nice because they are also used in the colorscheme, however the yellow isn't used a lot in code highlighting and that makes it feel out of place since the yellow doesn't quite match the dark and matt theme of gotham. One option could be to add a feature toggle that could be set in people their vimrc to make insert and visual mode stand out more. Other colorschemes have similar configuration variables where they can increase or decrease the contrast of the colorscheme for example. (see solarized and base16) |
I am 👎 against adding options for this. Let's:
Thoughts? |
You can try to add an option for increased contrast (which would mean yellow insert mode) and we can see how it looks. |
I'll work on that somewhere in the weekend. |
Ping @alexanderjeurissen? |
@whatyouhide sorry for the delay, I'm currently using another colorscheme so recently haven't work on this. I can tackle this next weekend. |
Ping @alexanderjeurissen? :) |
I just rebased on the latest master branch. |
@whatyouhide I just checked and vimscript let g:gotham_airline_contrast_mode = 0 in the colorscheme file, and ask people to override it. WDYT ? |
Let's default to contrasty insert, and let users override this if they want to. |
@whatyouhide which of the two values do you refer to with 'contrasty insert' you mean default to yellow insert ? if that is the case then I can leave the variable check as is and change the description in readme. |
@alexanderjeurissen yes, sorry for not being clear, I meant let's default to yellow insert and make non-yellow insert configurable. :) |
@whatyouhide updated the readme, and changed the name of the config variable to: |
Thanks a lot @alexanderjeurissen! 💟 |
This reverts commit 4507f9d.
This fixes #23
The default airline color used for insert mode doesn't really fit the overall look of gotham. Also the white on yellow makes it very hard to read that the active mode is insert.
This changes the color used for insert mode to magenta. See the screenshots below for (before / after)